Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin dask and distributed in CI #9307

Merged
merged 2 commits into from
Sep 27, 2021
Merged

[REVIEW] Unpin dask and distributed in CI #9307

merged 2 commits into from
Sep 27, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR unpins dask and distributed in CI.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 24, 2021
@galipremsagar galipremsagar self-assigned this Sep 24, 2021
@galipremsagar galipremsagar requested review from a team as code owners September 24, 2021 21:38
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Sep 24, 2021
This was referenced Sep 24, 2021
Merged
Merged
Merged
Merged
@codecov
Copy link

codecov bot commented Sep 25, 2021 •
edited
Loading

Codecov Report

Merging #9307 (c93b086) into branch-21.12 (ab4bfaa) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9307      +/-   ##
================================================
+ Coverage         10.79%   10.83%   +0.04%     
================================================
  Files               116      116              
  Lines             18869    19258     +389     
================================================
+ Hits               2036     2087      +51     
- Misses            16833    17171     +338
Impacted Files Coverage Δ
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908c130...c93b086. Read the comment docs.

charlesbluca
charlesbluca reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; could you point me to an issue / CI failure motivating this change?

galipremsagar
galipremsagar commented Sep 27, 2021
View reviewed changes
conda/environments/cudf_dev_cuda11.0.yml Outdated Show resolved Hide resolved
conda/environments/cudf_dev_cuda11.2.yml Outdated Show resolved Hide resolved
conda/recipes/custreamz/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
conda/recipes/dask-cudf/meta.yaml Outdated Show resolved Hide resolved
python/custreamz/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/dev_requirements.txt Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

LGTM; could you point me to an issue / CI failure motivating this change?

No issue or CI failure that triggered this PR.

We usually pin and restrict our users to certain versions of dask that are released only until the time of release, i.e., in this case for 21.10 we pinned the dask version to 2021.9.1, but we will need to unpin in 21.12 since it is now in development phase and then pin the dask version again during the release of 21.12.

charlesbluca
charlesbluca approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the the clarification @galipremsagar 🙂

@galipremsagar galipremsagar mentioned this pull request Sep 27, 2021
Merged
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Sep 27, 2021
@galipremsagar
Unpin dask & distributed in CI (#742)
78326ee 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - https://github.com/jakirkham
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #742
@shwina
Copy link
Contributor

shwina commented Sep 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4de968e into rapidsai:branch-21.12 Sep 27, 2021
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Sep 27, 2021
@galipremsagar
Unpin dask & distributed in CI (#338)
890c48e 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #338
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Oct 6, 2021
@galipremsagar
Unpin dask & distributed in CI (#4235)
119ac88 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4235
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Oct 11, 2021
@galipremsagar
Unpin dask & distributed (#1849)
5cc7799 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1849
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Unpin dask & distributed in CI (rapidsai#4235)
f558ef3 
Changes to be in-line with: rapidsai/cudf#9307

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jakirkham jakirkham jakirkham approved these changes

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @shwina @jakirkham @ajschmidt8 @charlesbluca