-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Apply modifications to account for RAFT changes #4077
[REVIEW] Apply modifications to account for RAFT changes #4077
Conversation
Removing Also, please consider using Draft pull requests instead of the For reference here's the GitHub docs on draft pull requests: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests#draft-pull-requests |
rerun tests |
2 similar comments
rerun tests |
rerun tests |
@viclafargue I think the only issue remaining to pass CI is correcting C++ docstrings!!!
|
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #4077 +/- ##
===============================================
Coverage ? 85.96%
===============================================
Files ? 232
Lines ? 18502
Branches ? 0
===============================================
Hits ? 15906
Misses ? 2596
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@gpucibot merge |
This PR apply modifications to the cuML codebase to account for changes in RAFT and RMM : - rapidsai/raft#283 - rapidsai/raft#285 - rapidsai/raft#286 - rapidsai/rmm#816 Authors: - Victor Lafargue (https://github.com/viclafargue) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) - Divye Gala (https://github.com/divyegala) URL: rapidsai#4077
This PR apply modifications to the cuML codebase to account for changes in RAFT and RMM :
device::buffer
adapter with RMMdevice_uvector
raft#283device::allocator
adapter raft#285