Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fixing remaining hdbscan bug #4179

Merged
merged 11 commits into from
Sep 1, 2021
Merged

[REVIEW] Fixing remaining hdbscan bug #4179

merged 11 commits into from
Sep 1, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Aug 27, 2021

Closes #4054

@cjnolet cjnolet added the 3 - Ready for Review Ready for review by team label Aug 27, 2021
@cjnolet cjnolet requested review from a team as code owners August 27, 2021 00:11
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Aug 27, 2021
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue CUDA/C++ labels Aug 27, 2021
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Aug 27, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Aug 30, 2021

rerun tests

dantegd
dantegd requested changes Aug 30, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just had a few comments

cpp/src/hdbscan/detail/reachability.cuh Show resolved Hide resolved
cpp/src/hdbscan/runner.h Outdated Show resolved Hide resolved
python/cuml/experimental/cluster/hdbscan.pyx Outdated Show resolved Hide resolved
python/cuml/test/test_hdbscan.py Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Aug 30, 2021
@cjnolet cjnolet added 3 - Ready for Review Ready for review by team 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review 3 - Ready for Review Ready for review by team labels Aug 31, 2021
dantegd
dantegd approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dantegd
Copy link
Member

dantegd commented Aug 31, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@903d576). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #4179   +/-   ##
===============================================
  Coverage                ?   85.97%           
===============================================
  Files                   ?      231           
  Lines                   ?    18502           
  Branches                ?        0           
===============================================
  Hits                    ?    15907           
  Misses                  ?     2595           
  Partials                ?        0
Flag Coverage Δ
dask 47.33% <0.00%> (?)
non-dask 78.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903d576...21e83b2. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 7706130 into rapidsai:branch-21.10 Sep 1, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Fixing remaining hdbscan bug (rapidsai#4179)
7673880 
Closes rapidsai#4054

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HDBSCAN is marking points in dense regions as noise
3 participants
@cjnolet @dantegd @codecov-commenter