-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanup. #3575
Small cleanup. #3575
Conversation
trivialfis
commented
Mar 3, 2021
•
edited
Loading
edited
- Remove unused code.
- Fix comment.
* Remove unused code. * Fix comment. * Add missing header.
@trivialfis, really happy to see these prims being cleaned up a bit. Some of them haven't been touched much since the original version of UMAP was written back in 2019 and can really use some TLC. As a side note- the sparse prims have all been moved to RAFT and I've had #3554 open to remove them from cuml and adjust the includes to use the versions from RAFT. Unfortunately, it hasn't been merged yet because it's been waiting on updates to other prims, which I need to update in RAFT again. It would be helpful if any sparse prims changes going forward are made directly in RAFT so that we can get #3554 merged quickly. |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3575 +/- ##
================================================
+ Coverage 44.99% 80.80% +35.80%
================================================
Files 223 227 +4
Lines 16921 17735 +814
================================================
+ Hits 7614 14331 +6717
+ Misses 9307 3404 -5903
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@cjnolet Thanks, let me look into raft tomorrow. Closing this. |
* Remove unused code. * Fix comments. Ported from rapidsai/cuml#3575 . Rebased onto 0.20. Authors: - Jiaming Yuan (https://github.com/trivialfis) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #203
* Remove unused code. * Fix comments. Ported from rapidsai/cuml#3575 . Rebased onto 0.20. Authors: - Jiaming Yuan (https://github.com/trivialfis) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#203