[REVIEW] Removing FusedL2NN and sparse prims from cuml #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: cpp/cmake/Dependencies.cmake cpp/src_prims/sparse/convert/coo.cuh cpp/src_prims/sparse/convert/csr.cuh cpp/src_prims/sparse/convert/dense.cuh cpp/src_prims/sparse/coo.cuh cpp/src_prims/sparse/csr.cuh cpp/src_prims/sparse/distance/bin_distance.cuh cpp/src_prims/sparse/distance/coo_spmv.cuh cpp/src_prims/sparse/distance/csr_spmv.cuh cpp/src_prims/sparse/distance/distance.cuh cpp/src_prims/sparse/distance/ip_distance.cuh cpp/src_prims/sparse/distance/l2_distance.cuh cpp/src_prims/sparse/distance/lp_distance.cuh cpp/src_prims/sparse/linalg/add.cuh cpp/src_prims/sparse/linalg/degree.cuh cpp/src_prims/sparse/linalg/norm.cuh cpp/src_prims/sparse/linalg/spectral.cuh cpp/src_prims/sparse/linalg/symmetrize.cuh cpp/src_prims/sparse/linalg/transpose.h cpp/src_prims/sparse/op/filter.cuh cpp/src_prims/sparse/op/row_op.cuh cpp/src_prims/sparse/op/slice.h cpp/src_prims/sparse/op/sort.h cpp/src_prims/sparse/selection/knn.cuh cpp/src_prims/sparse/selection/selection.cuh
cjnolet
added
3 - Ready for Review
cjnolet
changed the title
|
Before this PR is merged, the current versions of the brute force knn (both dense and sparse), as well as the sparse distance prims, need to be moved back out to raft. This will be possible once #3389 is merged. |
|
Removing |
ajschmidt8
reviewed
Feb 24, 2021
Co-authored-by: AJ Schmidt <[email protected]>
|
@divyegala can you take a look? |
Closed
|
Closing in favor of #3578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding RAFT PR (rapidsai/raft#158) must be merged before this PR. This is fairly independent of other PRs, but is required for SLHC & HDBSCAN.
Closes #3555