Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Update cupy to >= 7.8 and remove unused build.sh script #3378

Merged
merged 8 commits into from
Feb 4, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 15, 2021

closes #3366

Also removes an older build.sh script that to my knowledge we don't use anymore

cc @beckernick who pointed out we need to bump it due to using cupy.full order parameter

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team Build or Dep Issues related to building the code or dependencies non-breaking Non-breaking change labels Jan 15, 2021
@dantegd dantegd requested a review from a team as a code owner January 15, 2021 00:18
@github-actions github-actions bot added Cython / Python Cython or Python issue Ops labels Jan 15, 2021
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dantegd
Copy link
Member Author

dantegd commented Jan 19, 2021

rerun tests

1 similar comment
@JohnZed
Copy link
Contributor

JohnZed commented Jan 21, 2021

rerun tests

@JohnZed
Copy link
Contributor

JohnZed commented Jan 29, 2021

@gpucibot merge

@dantegd dantegd requested a review from a team as a code owner February 1, 2021 16:47
@dantegd
Copy link
Member Author

dantegd commented Feb 2, 2021

rerun tests

@JohnZed
Copy link
Contributor

JohnZed commented Feb 4, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit 39c7262 into rapidsai:branch-0.18 Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Build or Dep Issues related to building the code or dependencies Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bump conda required CuPy to >=7.8
4 participants