Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cupy to >= 7.8 #7166

Closed
wants to merge 1 commit into from
Closed

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jan 19, 2021

PR to update CuPy to version 7.8 to keep versions in sync (cuML requires 7.8 as of rapidsai/cuml#3378 due to usage of cupy.full order parameter) and corresponds to integration PR rapidsai/integration#208

cc @ajschmidt8

@dantegd dantegd requested a review from a team as a code owner January 19, 2021 15:44
@dantegd dantegd added conda non-breaking Non-breaking change labels Jan 19, 2021
@ajschmidt8 ajschmidt8 added the improvement Improvement / enhancement to an existing function label Jan 21, 2021
@ajschmidt8
Copy link
Member

rerun tests

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #7166 (9428f10) into branch-0.18 (8860baf) will increase coverage by 0.08%.
The diff coverage is 76.47%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7166      +/-   ##
===============================================
+ Coverage        82.09%   82.17%   +0.08%     
===============================================
  Files               97       97              
  Lines            16474    16589     +115     
===============================================
+ Hits             13524    13632     +108     
- Misses            2950     2957       +7     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/core/dataframe.py 90.49% <ø> (-0.22%) ⬇️
python/cudf/cudf/io/orc.py 86.89% <55.55%> (-1.51%) ⬇️
python/cudf/cudf/core/dtypes.py 89.50% <66.66%> (-0.88%) ⬇️
python/cudf/cudf/io/csv.py 91.66% <77.77%> (-1.67%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.08% <100.00%> (-0.33%) ⬇️
python/cudf/cudf/core/reshape.py 91.19% <100.00%> (+0.16%) ⬆️
python/cudf/cudf/core/series.py 91.10% <100.00%> (-0.06%) ⬇️
python/cudf/cudf/utils/cudautils.py 48.38% <0.00%> (-0.17%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835ccf9...9428f10. Read the comment docs.

@@ -35,7 +35,7 @@ requirements:
- protobuf
- python
- pandas >=1.0,<1.2.0dev0
- cupy >7.1.0,<9.0.0a0
- cupy >=7.8.0,<9.0.0a0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to restrict it to >=7.8.0 when cuDF doesn't use any newer features of CuPy?

@dantegd dantegd closed this Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants