-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cupy to >= 7.8 #7166
Update cupy to >= 7.8 #7166
Conversation
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7166 +/- ##
===============================================
+ Coverage 82.09% 82.17% +0.08%
===============================================
Files 97 97
Lines 16474 16589 +115
===============================================
+ Hits 13524 13632 +108
- Misses 2950 2957 +7
Continue to review full report at Codecov.
|
@@ -35,7 +35,7 @@ requirements: | |||
- protobuf | |||
- python | |||
- pandas >=1.0,<1.2.0dev0 | |||
- cupy >7.1.0,<9.0.0a0 | |||
- cupy >=7.8.0,<9.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to restrict it to >=7.8.0
when cuDF doesn't use any newer features of CuPy?
PR to update CuPy to version 7.8 to keep versions in sync (cuML requires 7.8 as of rapidsai/cuml#3378 due to usage of cupy.full order parameter) and corresponds to integration PR rapidsai/integration#208
cc @ajschmidt8