[REVIEW] Use device_buffer in tSNE, fix limitation on number of rows #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
zbjornson
force-pushed
the
bug-tsne-cleanup
branch
2 times, most recently
from
3d87fdd to
82b3847
Compare
zbjornson
changed the title
zbjornson
force-pushed
the
bug-tsne-cleanup
branch
from
82b3847 to
e0d290f
Compare
cjnolet
requested changes
Jul 12, 2020
|
ok to test |
dantegd
added
4 - Waiting on Author
zbjornson
force-pushed
the
bug-tsne-cleanup
branch
2 times, most recently
from
639eaf9 to
f018549
Compare
|
@cjnolet thank you for the review. Sorry for the back and forth on buffer/pointer style. Hope I got what you mean. The CI failure looks unrelated to this PR. The same failures are happening in other PRs (e.g. #2560). |
|
rerun tests |
|
@zbjornson the unrelated CI issue has been fixed now, so things should be fine now for running tests for the PR |
zbjornson
changed the title
cjnolet
requested changes
Jul 20, 2020
Ownership is entirely within TSNE_fit now for clarity.
Affects tSNE only. Fixes rapidsai#1753
Continuation of rapidsai#2542, see rapidsai#2542 (comment)
zbjornson
force-pushed
the
bug-tsne-cleanup
branch
from
f018549 to
fc7fc9f
Compare
cjnolet
added
4 - Waiting on Reviewer
cjnolet
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tempting to add
operator value_type*() { return _data; }tobuffer_baseso that they can implicitly convert toT*and not have to use.data()everywhere. Not sure if that would reduce type safety too much?Commits separated into logical units for easier review.
Fixes #2402 (i.e. #1101)
Includes a big chunk of #1356
Fixes #1753