Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update T-SNE to use device_buffer #2402

Closed
cjnolet opened this issue Jun 11, 2020 · 0 comments · Fixed by #2548
Closed

[FEA] Update T-SNE to use device_buffer #2402

cjnolet opened this issue Jun 11, 2020 · 0 comments · Fixed by #2548
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Jun 11, 2020

There are very few algorithms left that do not use device_buffer. Like many algorithms, T-SNE was written just before the device_buffer was created so it's still using the underlying allocator directly.

The allocations done on heap should be replaced with stack device_buffer to make the code generally easier to maintain.
@cjnolet cjnolet added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 11, 2020
@hcho3 hcho3 removed the ? - Needs Triage Need team to review and classify label Jun 18, 2020
@zbjornson zbjornson mentioned this issue Jul 12, 2020
Merged
zbjornson added a commit to zbjornson/cuml that referenced this issue Jul 21, 2020
@zbjornson
Use device_buffer in tSNE impls
1b81330 
Ref rapidsai#1101
Ref rapidsai#2402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Use device_buffer in tSNE, fix limitation on number of rows zbjornson/cuml
2 participants
@cjnolet @hcho3