Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update umap n_epochs default value #2540

Merged
merged 3 commits into from
Jul 13, 2020
Merged

[REVIEW] Update umap n_epochs default value #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
072946a
update umap n_epochs default value
Salonijain27 Jul 10, 2020
4bdecca
update changelog.md
Salonijain27 Jul 10, 2020
adc769e
Merge branch 'branch-0.15' into update-umap-nepochs
Salonijain27 Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
- PR #2507: Import `treelite.sklearn`
- PR #2521: Fixing invalid smem calculation in KNeighborsCLassifier
- PR #2515: Increase tolerance for LogisticRegression test
- PR #2540: Update default value for n_epochs in UMAP to match documentation & sklearn API
- PR #2535: Fix issue with incorrect docker image being used in local build script
- PR #2542: Fix small memory leak in TSNE

Expand Down
4 changes: 2 additions & 2 deletions python/cuml/manifold/umap.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class UMAP(Base):
def __init__(self,
n_neighbors=15,
n_components=2,
n_epochs=0,
n_epochs=None,
learning_rate=1.0,
min_dist=0.1,
spread=1.0,
Expand Down Expand Up @@ -306,7 +306,7 @@ class UMAP(Base):

self.n_neighbors = n_neighbors
self.n_components = n_components
self.n_epochs = n_epochs
self.n_epochs = n_epochs if n_epochs else 0

if init == "spectral" or init == "random":
self.init = init
Expand Down