Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update umap n_epochs default value #2540

Merged
merged 3 commits into from
Jul 13, 2020
Merged

[REVIEW] Update umap n_epochs default value #2540

merged 3 commits into from
Jul 13, 2020

Conversation

Salonijain27
Copy link
Contributor

@Salonijain27 Salonijain27 commented Jul 10, 2020 •
edited
Loading

Update UMAP to pass None as the default value for n_epochs to match the cuml documentation and to match sklearn's API

@Salonijain27 Salonijain27 requested a review from a team as a code owner July 10, 2020 21:06
@Salonijain27
Copy link
Contributor Author

CC @taureandyernv

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@Salonijain27 Salonijain27 added 3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue labels Jul 10, 2020
cjnolet
cjnolet approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salonijain27 Salonijain27 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 13, 2020
@JohnZed JohnZed merged commit 2168761 into rapidsai:branch-0.15 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Salonijain27 @GPUtester @cjnolet @JohnZed