[REVIEW] add logger in cuML C++ #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ea-ext-add-logger
… a given level. Useful to cull log-message construction
…d control over logging in dbscan algo
teju85
commented
Apr 10, 2020
| @@ -165,6 +165,14 @@ class Base: | |||
| """ | |||
| self.handle = cuml.common.handle.Handle() if handle is None else handle | |||
| self.verbose = verbose | |||
| # NOTE: | |||
There was a problem hiding this comment.
Issue #2052 has been filed for this.
cjnolet
reviewed
Apr 10, 2020
|
Dbscan looks good to me. |
|
Great. Since you're ok with this approach, I'll resolve the remaining 2 conversations on this logging thingy and will soon be updating all other algos currently using 'verbose' flag too. |
This was referenced Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR for all logger-related issues in cuML:
spdlog-based logging capability in cuML (issue [TASK] [DEBT] Use GLOG in the cuML's back-end #100).*_NO_THROWmacros (issue [FEA] [DEBT] support for CUDA_CHECK_NO_THROW macro #229) using these logging methods. In this process, it also fixes theexitissue with the cublas/cusolver macros (issue [FEA] [DEBT] Improve CUBLAS_CHECK and CUSOLVER_CHECK macros #240) as well as issue [DEBT] there are 2 cusparse_wrappers.h header files inside ml-prims #1691, as a by-product.*_NO_THROWmacros. This also means it fixes issue [FEA] [DEBT] Move CUBLAS_CHECK and CUSOLVER_CHECK to a headers that can be used in cpp files #239 .Tagging @cjnolet, @dantegd and @JohnZed for discussions. (Guys, needless to say, this can certainly wait until 0.13 release!) Please note that even though the number of files touched is large, not the number of changes aren't, as this only updates the portions of these sources needing logging infra.
PS: Currently, I'm keeping the target branch as 0.13, but will update it to 0.14 once it becomes default.