Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] [DEBT] support for CUDA_CHECK_NO_THROW macro #229

Closed
teju85 opened this issue Feb 21, 2019 · 1 comment
Closed

[FEA] [DEBT] support for CUDA_CHECK_NO_THROW macro #229

teju85 opened this issue Feb 21, 2019 · 1 comment
Labels
0 - Backlog In queue waiting for assignment CUDA / C++ CUDA issue good first issue Good for newcomers Tech Debt Issues related to debt

Comments

@teju85
Copy link
Member

teju85 commented Feb 21, 2019

Is your feature request related to a problem? Please describe.
We need a non-throwing checker macro CUDA_CHECK_NO_THROW which doesn't throw exception, but only logs the error. This is certainly useful for calling cudaFree, for example, from a destructor. However, I'd prefer for us to solve the logging mechanism first in issue #100 before doing this.

Describe the solution you'd like
Implement CUDA_CHECK_NO_THROW and similarly for CUBLAS_CHECK_NO_THROW and CUSOLVER_CHECK_NO_THROW, to be consistent.

Describe alternatives you've considered
This was a very valid request from @jirikraus . And one way we could work-around currently is to use try-catch-and-ignore blocks. But, IMO, this is a not great solution.

Additional context
None.
@teju85 teju85 added ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 21, 2019
@teju85 teju85 mentioned this issue Feb 21, 2019
Merged
@dantegd dantegd added 0 - Backlog In queue waiting for assignment and removed ? - Needs Triage Need team to review and classify feature request New feature or request labels Feb 21, 2019
Salonijain27 pushed a commit to Salonijain27/cuml that referenced this issue Jan 22, 2020
@taureandyernv
Merge pull request rapidsai#229 from rlratzel/branch-0.10-mastermerge
882ee2c 
Merging changes from master into branch-0.10.  

Ran a partial test due to nightly docker issues.  Code looks good and tested, changed notebooks run.  90% certainty everything's good.  merging so that we don't become a blocker for CI.  Will keep testing on new nightly docker.
@teju85 teju85 added CUDA / C++ CUDA issue good first issue Good for newcomers Tech Debt Issues related to debt labels Feb 17, 2020
@teju85 teju85 changed the title [FEA] support for CUDA_CHECK_NO_THROW macro [FEA] [DEBT] support for CUDA_CHECK_NO_THROW macro Feb 17, 2020
@teju85 teju85 mentioned this issue Mar 16, 2020
Merged
teju85 added a commit to teju85/cuml that referenced this issue Mar 16, 2020
@teju85
added CUBLAS_CHECK_NO_THROW issue rapidsai#229
1a5cf71
teju85 added a commit to teju85/cuml that referenced this issue Mar 16, 2020
@teju85
added CUSOLVER_CHECK_NO_THROW issue rapidsai#229
0ec9a02
teju85 added a commit to teju85/cuml that referenced this issue Mar 16, 2020
@teju85
added CUSPARSE_CHECK_NO_THROW issue rapidsai#229
bbf3200
@teju85
Copy link
Member Author

teju85 commented Apr 15, 2020

Closing as it has been addressed in PR #1867.

@teju85 teju85 closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - Backlog In queue waiting for assignment CUDA / C++ CUDA issue good first issue Good for newcomers Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teju85 @dantegd