Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RF : regression in GPU predict accuracy compared to CPU predict and scikit-learn predict #3910

Closed
venkywonka opened this issue May 28, 2021 · 0 comments · Fixed by #3933
Assignees
Labels
bug Something isn't working

Comments

@venkywonka
Copy link
Contributor

venkywonka commented May 28, 2021

Describe the bug
After #3869 , some cuml predictions on GPU (FIL) seems to be less accurate than CPU predictions and tends to break tolerance (when set to 2%) of some of the tests in test_random_forest.py.

printing the cuml_acc and fil_acc respectively for each build version after running the above test at this line:

Steps/Code to reproduce bug

  • pytest cuml/python/cuml/test/test_random_forest.py --run_quality --run_stress --run_unit -v

  • or this particular test:
    pytest $CUML_PATH/python/cuml/test/test_random_forest.py::test_rf_classification[small_clf0-auto-1-float32-0.9] -v --run_quality -- run_stress --run_unit

Expected behavior
tests expected to pass

Environment details (please complete the following information):

  • Environment location: [Bare-metal]
  • Linux Distro/Architecture: [Ubuntu 18.04 amd64]
  • GPU Model/Driver: [V100 and driver 460.35]
  • CUDA: [11.0]
  • Method of cuDF & cuML install: [from source]
    • If method of install is [from source], provide versions of cmake & gcc/g++ and commit hash of build:
      • cmake: 3.20.1, gcc/g++: 9.3.0, commit hash: 92484fb99aa390dc24aeb86a67abf259bfaadf55
@venkywonka venkywonka added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 28, 2021
@venkywonka venkywonka self-assigned this May 28, 2021
@Nanthini10 Nanthini10 removed the ? - Needs Triage Need team to review and classify label May 28, 2021
@venkywonka venkywonka changed the title [BUG] RF accuracy gap between FIL and RF CPU prediction failing pytest [BUG] RF : regression in GPU predict accuracy compared to CPU predict and scikit-learn predict Jun 2, 2021
@hcho3 hcho3 mentioned this issue Jun 2, 2021
@rapids-bot rapids-bot bot closed this as completed in #3933 Jun 2, 2021
rapids-bot bot pushed a commit that referenced this issue Jun 2, 2021
Reverts #3869, as it was shown to reduce the test accuracy in some cases.

Closes #3910

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #3933
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
Reverts rapidsai#3869, as it was shown to reduce the test accuracy in some cases.

Closes rapidsai#3910

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants