Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] SVM row major input #2198

Open
tfeher opened this issue May 5, 2020 · 2 comments
Open

[FEA] SVM row major input #2198

tfeher opened this issue May 5, 2020 · 2 comments

Comments

@tfeher
Copy link
Contributor

tfeher commented May 5, 2020

Is your feature request related to a problem? Please describe.
SVM currently uses column major input matrices. Row major input needs to be transposed which is done by creating a copy of the feature matrix in column major format. This increases the memory consumption of SVM.

Describe the solution you'd like
Implement support for row major feature matrix.

Additional context
Since the memory layout only enters only during the kernel matrix calculation, one could implement support for row major input with a relatively small effort.

@tfeher tfeher added ? - Needs Triage Need team to review and classify feature request New feature or request labels May 5, 2020
@Garfounkel Garfounkel removed the ? - Needs Triage Need team to review and classify label May 5, 2020
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Mar 31, 2021
This PR add row major Gram matrices. These will be used in SVM kernels to allow flexibility in the input layout (#2198).

For the benchmarked cases, row major input is around 2.5% slower on average.

![image](https://user-images.githubusercontent.com/3671106/111769429-8361b000-88a9-11eb-85e1-145caf5f42b2.png)

Authors:
  - Tamas Bela Feher (@tfeher)

Approvers:
  - Thejaswi. N. S (@teju85)
  - Dante Gama Dessavre (@dantegd)

URL: #3639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants