Skip to content

Commit

Permalink
Merge pull request #2799 from levsnv/reenable-lightgbm-test
Browse files Browse the repository at this point in the history
[REVIEW] reenable lightgbm test with a lower (1%) proba accuracy threshold
  • Loading branch information
dantegd authored Sep 9, 2020
2 parents 672517d + cbf78dd commit 80a86b7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- PR #2783: Add pytest that will fail when GPU IDs in Dask cluster are not unique
- PR #2785: Add in cuML-specific dev conda dependencies
- PR #2778: Add README for FIL
- PR #2799: Reenable lightgbm test with lower (1%) proba accuracy
- PR #2800: Align cuML's spdlog version with RMM's

## Bug Fixes
Expand Down
5 changes: 1 addition & 4 deletions python/cuml/test/test_fil.py
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,6 @@ def test_output_args(small_classifier_and_preds):
@pytest.mark.skipif(has_lightgbm() is False, reason="need to install lightgbm")
def test_lightgbm(tmp_path):
import lightgbm as lgb
from distutils.version import LooseVersion
if LooseVersion(lgb.__version__) >= LooseVersion('3.0.0'):
pytest.skip('lightgbm version 3 support is underway.')
X, y = simulate_data(500, 10,
random_state=43210,
classification=True)
Expand Down Expand Up @@ -436,4 +433,4 @@ def test_lightgbm(tmp_path):
fil_proba = np.asarray(fm.predict_proba(X))
fil_proba = np.reshape(fil_proba, np.shape(gbm_proba))

assert np.allclose(gbm_proba, fil_proba, 1e-3)
assert np.allclose(gbm_proba, fil_proba, 1e-2)

0 comments on commit 80a86b7

Please sign in to comment.