Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Set Max PyTorch Version, Skip 11.4 Tests Using WholeGraph #4808

Merged
merged 6 commits into from
Dec 6, 2024
Merged

[BUG] Set Max PyTorch Version, Skip 11.4 Tests Using WholeGraph #4808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e4a15e
set max pt version, skip 11.4 tests using wg
alexbarghi-nv Dec 5, 2024
9ad4278
Add alpha limit
alexbarghi-nv Dec 6, 2024
5574c41
use different function for getting cudart version
alexbarghi-nv Dec 6, 2024
03d63ae
Merge branch 'skip-114' of https://github.com/alexbarghi-nv/cugraph i…
alexbarghi-nv Dec 6, 2024
85fa7fe
rerun generator
alexbarghi-nv Dec 6, 2024
5c58965
restore wholegraph check
alexbarghi-nv Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ dependencies:
- pytest-cov
- pytest-xdist
- python-louvain
- pytorch>=2.3
- pytorch>=2.3,<2.5a0
- raft-dask==24.12.*,>=0.0.0a0
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- rapids-dask-dependency==24.12.*,>=0.0.0a0
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-125_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ dependencies:
- pytest-cov
- pytest-xdist
- python-louvain
- pytorch>=2.3
- pytorch>=2.3,<2.5a0
- raft-dask==24.12.*,>=0.0.0a0
- rapids-build-backend>=0.3.1,<0.4.0.dev0
- rapids-dask-dependency==24.12.*,>=0.0.0a0
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ dependencies:
common:
- output_types: [conda]
packages:
- &pytorch_conda pytorch>=2.3
- &pytorch_conda pytorch>=2.3,<2.5a0
- torchdata
- pydantic
- ogb
Expand Down
13 changes: 13 additions & 0 deletions python/cugraph/cugraph/tests/data_store/test_gnn_feat_storage_wholegraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
import numpy as np
import os

import numba.cuda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update dependencies.yaml to also include this new dependency, or is it already included or covered some other way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind, I see it's already a dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered by cudf https://github.com/rapidsai/cudf/blob/38261f8509245f88bdeab193a1357d9c73d765f0/dependencies.yaml#L692


from cugraph.gnn import FeatureStore

from cugraph.utilities.utils import import_optional, MissingModule
Expand All @@ -25,6 +27,11 @@
wgth = import_optional("pylibwholegraph.torch")


def get_cudart_version():
major, minor = numba.cuda.runtime.get_version()
return major * 1000 + minor * 10


def runtest(rank: int, world_size: int):
torch.cuda.set_device(rank)

Expand Down Expand Up @@ -66,6 +73,9 @@ def runtest(rank: int, world_size: int):
@pytest.mark.skipif(
isinstance(pylibwholegraph, MissingModule), reason="wholegraph not available"
)
@pytest.mark.skipif(
get_cudart_version() < 11080, reason="not compatible with CUDA < 11.8"
)
def test_feature_storage_wholegraph_backend():
world_size = torch.cuda.device_count()
print("gpu count:", world_size)
Expand All @@ -81,6 +91,9 @@ def test_feature_storage_wholegraph_backend():
@pytest.mark.skipif(
isinstance(pylibwholegraph, MissingModule), reason="wholegraph not available"
)
@pytest.mark.skipif(
get_cudart_version() < 11080, reason="not compatible with CUDA < 11.8"
)
def test_feature_storage_wholegraph_backend_mg():
world_size = torch.cuda.device_count()
print("gpu count:", world_size)
Expand Down
Loading