Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Set Max PyTorch Version, Skip 11.4 Tests Using WholeGraph #4808

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

alexbarghi-nv
Copy link
Member

Set Max PyTorch Version, Skip 11.4 Tests Using WholeGraph

@alexbarghi-nv alexbarghi-nv requested review from a team as code owners December 5, 2024 20:20
@alexbarghi-nv alexbarghi-nv requested a review from bdice December 5, 2024 20:20
@alexbarghi-nv alexbarghi-nv self-assigned this Dec 5, 2024
@alexbarghi-nv alexbarghi-nv added CRITICAL BUG! BUG that needs to be FIX NOW !!!! breaking Breaking change bug Something isn't working and removed python conda labels Dec 5, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix is probably needed for the conditionally skipped tests on earlier CUDA versions.

dependencies.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <[email protected]>
@@ -15,6 +15,8 @@
import numpy as np
import os

import numba.cuda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update dependencies.yaml to also include this new dependency, or is it already included or covered some other way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nevermind, I see it's already a dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 58075dd into rapidsai:branch-24.12 Dec 6, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working conda CRITICAL BUG! BUG that needs to be FIX NOW !!!! python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants