Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triangle count to internally use edge masking and update Triangle counting & K-hop neighbor tests to include edge masked graph view inputs #4261

Merged
merged 22 commits into from
Apr 8, 2024

Conversation

seunghwak
Copy link
Contributor

This PR pulls updates from #4253
Better be reviewed after #4253 is merged.

  • Update triangle count to internally use edge masking (this is cheaper than creating a new graph in both memory footprint and compute) to
    • include only the edges with endpoints reachable within two hops (if the list of vertices to compute triangle counts is provided)
    • Exclude self-loops
    • Exclude vertices that do not belong to 2-Core
    • Note that we are still creating a new graph when we are creating a degree ordered directed graph (as this graph is now significantly smaller than the original graph and edge masking has non-negligible overhead and computing triangle counts on the final degree ordered directed graph is computationally intensive).
  • Update SG/MG Triangle counting & K-hop neighbors C++ tests to include edge masked graph view inputs

@seunghwak seunghwak requested review from a team as code owners March 20, 2024 00:46
@seunghwak seunghwak self-assigned this Mar 20, 2024
@seunghwak seunghwak added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Mar 20, 2024
@seunghwak seunghwak added this to the 24.06 milestone Mar 20, 2024
@github-actions github-actions bot removed the CMake label Mar 20, 2024
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Mar 20, 2024
Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit abe69c0 into rapidsai:branch-24.06 Apr 8, 2024
132 checks passed
@seunghwak seunghwak deleted the enh_tc_with_mask branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants