Refactor test utility functions and update SG & MG core_number tests to test with edge masking #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to enh_mask_test_utils
seunghwak
added
improvement
…to enh_mask_test_utils
jnke2016
approved these changes
Mar 18, 2024
ChuckHastings
approved these changes
Mar 19, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
…gle counting & K-hop neighbor tests to include edge masked graph view inputs (#4261) This PR pulls updates from #4253 Better be reviewed after #4253 is merged. * Update triangle count to internally use edge masking (this is cheaper than creating a new graph in both memory footprint and compute) to * include only the edges with endpoints reachable within two hops (if the list of vertices to compute triangle counts is provided) * Exclude self-loops * Exclude vertices that do not belong to 2-Core * Note that we are still creating a new graph when we are creating a degree ordered directed graph (as this graph is now significantly smaller than the original graph and edge masking has non-negligible overhead and computing triangle counts on the final degree ordered directed graph is computationally intensive). * Update SG/MG Triangle counting & K-hop neighbors C++ tests to include edge masked graph view inputs Authors: - Seunghwa Kang (https://github.com/seunghwak) Approvers: - Joseph Nke (https://github.com/jnke2016) - Naim (https://github.com/naimnv) - Chuck Hastings (https://github.com/ChuckHastings) URL: #4261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had
test_utilities.hpphaving all different sorts of function declarations andproperty_generator.cuh(which is necessary to create an edge mask) was only for primitives testing.This PR divides
test_utilities.hppto multiple files (check_utilities.hpp,conversion_utilities.hpp,csv_file_utilities.hpp,matrix_market_file_utilities.hpp, andmisc_utilties.hpp) renamed/movedtests/prims/property_generator.cuhtotests/utilities/property_generator_utilities.hpp(now this file can be included from .cpp files).Updated SG & MG core_number tests to use property generator to create an edge mask.