Fix PyG Loaders by properly supporting multi_get_tensor
#2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this only does SG version for rapidsai#2401. MG is still TODO. This also doesn't change anything user-facing (yet).
This includes a slow workaround for rapidsai/cudf#11550
…nto cgs-remote-wrappers
…to cgs-remote-wrappers
…to cgs-remote-sample
…to cgs-remote-sample
Co-authored-by: Vibhu Jawa <[email protected]>
Codecov ReportBase: 60.80% // Head: 60.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2860 +/- ##
================================================
- Coverage 60.80% 60.78% -0.03%
================================================
Files 122 122
Lines 6891 6915 +24
================================================
+ Hits 4190 4203 +13
- Misses 2701 2712 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eriknw
reviewed
Nov 14, 2022
eriknw
reviewed
Nov 14, 2022
rlratzel
requested changes
Nov 15, 2022
python/cugraph/cugraph/gnn/pyg_extensions/data/cugraph_store.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/gnn/pyg_extensions/data/cugraph_store.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/gnn/pyg_extensions/sampler/cugraph_sampler.py
Outdated
Show resolved
Hide resolved
eriknw
reviewed
Nov 15, 2022
rlratzel
approved these changes
Nov 15, 2022
|
rerun tests reason: git checkout failure |
eriknw
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Property graph changes look good to me. I left a couple non-critical nitpicky comments.
Thanks for working on this @alexbarghi-nv!
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the currently-broken
pyg_hetero_magnotebook, which fails due to the sampling output not matching what the API expects. Note: this does use an optional import of PyG, similar to how other code optionally usestorchorcudf.Also adds an in-place
fillnafunction forPropertyGraphandMGPropertyGraph. There is a separate issue to do this forRemoteGraph(https://github.com/rapidsai/graph_dl/issues/97).Also removes an unintended dependence on
cugraphby addingis_multi_gpu()methods toPropertyGraphandMGPropertyGraphso whether a graph is MG can be determined without importingcugraph.Closes https://github.com/rapidsai/graph_dl/issues/78
Closes https://github.com/rapidsai/graph_dl/issues/77
Closes https://github.com/rapidsai/graph_dl/issues/63
Merge after #2832