Cugraph-Service Remote Graphs and Algorithm Dispatch #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this only does SG version for rapidsai#2401. MG is still TODO. This also doesn't change anything user-facing (yet).
This includes a slow workaround for rapidsai/cudf#11550
…nto cgs-remote-wrappers
…to cgs-remote-wrappers
…to cgs-remote-sample
…to cgs-remote-sample
alexbarghi-nv
added
feature request
|
rerun tests |
rlratzel
reviewed
Nov 8, 2022
python/cugraph_service/cugraph_service_client/remote_graph_utils.py
Outdated
Show resolved
Hide resolved
python/cugraph_service/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
python/cugraph_service/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
VibhuJawa
suggested changes
Nov 8, 2022
python/cugraph_service/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
python/cugraph_service/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
python/cugraph_service/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
2 tasks
rlratzel
approved these changes
Nov 9, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
Fixes the currently-broken `pyg_hetero_mag` notebook, which fails due to the sampling output not matching what the API expects. Note: this does use an optional import of PyG, similar to how other code optionally uses `torch` or `cudf`. Also adds an in-place `fillna` function for `PropertyGraph` and `MGPropertyGraph`. There is a separate issue to do this for `RemoteGraph` (rapidsai/graph_dl#97). Also removes an unintended dependence on `cugraph` by adding `is_multi_gpu()` methods to `PropertyGraph` and `MGPropertyGraph` so whether a graph is MG can be determined without importing `cugraph`. Closes rapidsai/graph_dl#78 Closes rapidsai/graph_dl#77 Closes rapidsai/graph_dl#63 Merge after #2832 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Erik Welch (https://github.com/eriknw) URL: #2860
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/rapidsai/graph_dl/issues/80
This PR combines
RemoteGraphandRemotePropertyGraph, adds support for remote API calls to cugraph.Graph, adds subgraph extraction to the property graph wrappers, adds the ability to dispatch cuGraph algorithms (though currently onlyuniform_neighbor_sampleis supported), better supports multigraphs for subgraph extraction, properly handles renumbering on the server, and supports implicit subgraph extraction for remote graphs.