Add core number to the C API #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betochimas
added
2 - In Progress
improvement
Merging commits from Jun 6
Merge commits from Jun 6-15
Merge branch-22.08 into branch-22.08-core
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2338 +/- ##
================================================
+ Coverage 60.11% 60.15% +0.03%
================================================
Files 102 102
Lines 5155 5157 +2
================================================
+ Hits 3099 3102 +3
+ Misses 2056 2055 -1
Continue to review full report at Codecov.
|
seunghwak
approved these changes
Jul 14, 2022
jnke2016
reviewed
Jul 14, 2022
| * @param [in] handle Handle for accessing resources | ||
| * @param [in] graph Pointer to graph | ||
| * @param [in] do_expensive_check A flag to run expensive checks for input arguments (if set to | ||
| * `true`). |
There was a problem hiding this comment.
I think you forgot the docstring for degree_type?
jnke2016
approved these changes
Jul 14, 2022
ChuckHastings
approved these changes
Jul 15, 2022
rlratzel
approved these changes
Jul 15, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses parts of #2169, notably the libcugraph_c API for core number, implemented in
src/c_api/core_number.cpp, with relevant header updates. Testing had been started for the sg variant intests/c_api/core_number_test.c, though results are currently not matching up with what's expected. Testing for the mg variant intests/c_api/mg_core_number_test.chas not been started.Also, the pylibcugraph wrapper for core number is included (not tested yet), so this PR can include both APIs or be split into 2 separate PRs, one for each level.