Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commits from Jun 6-15 #85

Merged
merged 7 commits into from
Jun 16, 2022
Merged

Merge commits from Jun 6-15 #85

merged 7 commits into from
Jun 16, 2022

Conversation

betochimas
Copy link
Owner

Merges a total of 7 commits, (clean up some unused C code, fix sampling bug, remove legacy sssp, performance-optimizing edge partition, release notebook, update ops-bot.yaml, unpin dask&distributed for development

ChuckHastings and others added 7 commits June 6, 2022 22:44
Cleaning up some unused code in the C API, and some old visitor methods that are no longer used once this code is gone.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#2339
@jnke2016 found a bug in the sampling code.

Fix weight lookup to match index lookup.  The weight array mirrors the indices array in its structure, but the computation to do the lookup was correct for the indices array but incorrect for the weights array.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#2343
Legacy SSSP implementation should not be referenced any longer.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#2344
…ties in (key, value) pairs (rapidsai#2328)

Using (key, value) pairs instead of linear array for the entire source/destination range cuts memory footprint significantly when # GPUs >> (V/E)^2.

This PR performance-optimizes finding the value for the given key and also enables (key, value) pairs (this feature was previously disabled by default).

The original implementation binary searched over the entire set of local source/destination keys. This PR compared a hash table based approach (using cuCollection) and the auxiliary array based approach (described in the original DCSC paper) and selected the auxiliary array based approach. 

Breaking due to few graph primitives API changes.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Kumar Aatish (https://github.com/kaatish)

URL: rapidsai#2328
There was an issue where some Nx methods return a generator and not a full answer. These functions (WCC, Jaccard, and BFS) were identified and fixed for the purpose of getting more accurate ("apples-to-apples") comparisons against cuGraph methods. 

Next, `time.time()` was replaced with `time.perf_counter()` to get appropriate interval timings.

Authors:
  - Ralph Liu (https://github.com/oorliu)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#2341
@betochimas betochimas merged commit b2af027 into branch-22.08-core Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants