-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add API for the new uniform neighborhood sampling #2236
add API for the new uniform neighborhood sampling #2236
Conversation
@ChuckHastings So, in using the wedge weight as the edge index, are you planning to set weight_t to integer type? Or you plan to store integer in floating point format? I guess the latter will be less invasive (assuming there is no resolution issue for a very large number of edges). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was imagining I would instantiate |
rerun tests |
1 similar comment
rerun tests |
@gpucibot merge |
Added an API for the new uniform neighborhood sampling implementation.
Added the API with an experimental tag in its name so it won't break the current python code. Plan is to have the new API replace the existing API during this release.
Plan for this release will be to have the edge weight be an edge index (passed by the calling python code), so the return "index" value will be the edge weight. Down the road we will release this restriction and allow real edge weights.
Addresses part 1 of #2226