Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor libcugraph Neighborhood Sampling #2226

Closed
ChuckHastings opened this issue Apr 14, 2022 · 1 comment · Fixed by #2301
Closed

Refactor libcugraph Neighborhood Sampling #2226

ChuckHastings opened this issue Apr 14, 2022 · 1 comment · Fixed by #2301
Assignees
@ChuckHastings
Milestone
22.06

Comments

@ChuckHastings
Copy link
Collaborator

The following steps are required (each a separate PR):

  1. Update API as discussed in our meeting (remove batching, drop some of the return values)
  2. Refactor the implementation to use more of the existing primitives and support both SG and MG
@ChuckHastings ChuckHastings added this to the 22.06 milestone Apr 14, 2022
@ChuckHastings ChuckHastings self-assigned this Apr 14, 2022
@ChuckHastings ChuckHastings mentioned this issue Apr 21, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Apr 27, 2022
@ChuckHastings
add API for the new uniform neighborhood sampling (#2236)
2956d56 
Added an API for the new uniform neighborhood sampling implementation.

Added the API with an experimental tag in its name so it won't break the current python code.  Plan is to have the new API replace the existing API during this release.

Plan for this release will be to have the edge weight be an edge index (passed by the calling python code), so the return "index" value will be the edge weight.  Down the road we will release this restriction and allow real edge weights.

Addresses part 1 of #2226

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2236
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@ChuckHastings ChuckHastings mentioned this issue May 23, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue May 24, 2022
@ChuckHastings
Fix uniform neighborhood sampling remove duplicates (#2301)
4c0531d 
@jnke2016 observed that the recent sampling code can return duplicates.

After some discussion it was decided to remove the duplicates and return a count of how many duplicates were removed.  The C++ implementation is updated in this PR to do that.  The C API will remain the same but is ready to support it once we have stopped using the old implementation.

Closes #2226

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #2301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
None yet
Projects
None yet
Milestone
22.06
Development

Successfully merging a pull request may close this issue.

Fix uniform neighborhood sampling remove duplicates ChuckHastings/cugraph
1 participant
@ChuckHastings