-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch 22.06 merge 22.04 #2190
Merged
sevagh
merged 8 commits into
rapidsai:branch-22.06
from
rlratzel:branch-22.06-merge-22.04
Apr 5, 2022
Merged
Branch 22.06 merge 22.04 #2190
sevagh
merged 8 commits into
rapidsai:branch-22.06
from
rlratzel:branch-22.06-merge-22.04
Apr 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authors: - Brad Rees (https://github.com/BradReesWork) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#2171
Provide the implementation for the C API for neighborhood sampling. Currently needs some debugging. merge after 2150 Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: rapidsai#2156
This PR wraps the MG C++ implementation of HITS following the pylibcugraph API Awaiting MG support to the C API closes rapidsai#2026 Authors: - Joseph Nke (https://github.com/jnke2016) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Don Acosta (https://github.com/acostadon) - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#2088
…lgos (rapidsai#2099) Code to inherit all of networkx graph then call cugraph pagerank with just an import change. This was originally going to do bfs first but pargerank was considered a more useful first algorithm. Authors: - Don Acosta (https://github.com/acostadon) Approvers: - Brad Rees (https://github.com/BradReesWork) URL: rapidsai#2099
…sting coverage (rapidsai#2120) This PR was initially created because of two issues: 1. The pylibcugraph and cugraphs APIs differed from C++ and C because a compress flag was reinterpreted into a padding flag 2. Because of a renumbering bug, edges and vertices are not being renumbered correctly, causing multiple vertices and edges to be potentially identified as the same 3. Because of a type mismatching bug, `start_vertices` would yield garbage values and capture only half of the paths when using int64 values for vertices (this was initially thought to be a padding bug) What this PR does to address each: 1. Renamed the `use_padding` flag to `compress_result` to be inline with libcugraph. If a user desires to enforce padding to keep track of paths via formula, one would set `compress_result=False` (use_padding=True) 2. `random_walks.cpp` now unrenumbers local vertex ids for use with pylibcugraph and cugraph 3. node2vec now works with the requirement of using `int32` only for graph vertices. Future plans include adding support to `int64` and other types. Testing has been adapted from the C level, and further testing has been added to ensure invalid inputs are caught and results are expected with the new changes Authors: - https://github.com/betochimas - Rick Ratzel (https://github.com/rlratzel) Approvers: - Seunghwa Kang (https://github.com/seunghwak) - Chuck Hastings (https://github.com/ChuckHastings) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#2120
CMake 3.23 has a bug that breaks our conda-build based builds in CI, this avoids that issue. Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#2176
…#2118) Closes rapidsai#2108 when merged. Requires both rapidsai#2088 and rapidsai#2156 to be merged before, the former because this uses MGGraph, and the later because of the C implementation of neighborhood sampling. Authors: - https://github.com/betochimas - Joseph Nke (https://github.com/jnke2016) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Don Acosta (https://github.com/acostadon) - Rick Ratzel (https://github.com/rlratzel) - Joseph Nke (https://github.com/jnke2016) - Chuck Hastings (https://github.com/ChuckHastings) - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#2118
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2190 +/- ##
================================================
- Coverage 72.41% 69.40% -3.01%
================================================
Files 157 170 +13
Lines 10496 11036 +540
================================================
+ Hits 7601 7660 +59
- Misses 2895 3376 +481
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes merge conflict in #2172