Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Forward-merge branch-22.04 to branch-22.06 [skip gpuci] #2172

Merged
merged 7 commits into from
Apr 5, 2022

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-22.04 that creates a PR to keep branch-22.06 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

@GPUtester GPUtester requested review from a team as code owners March 29, 2022 15:27
@GPUtester
Copy link
Contributor Author

FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/gpuci/#forward-mergers
IMPORTANT: Before merging and approving this PR, be sure to change the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

Provide the implementation for the C API for neighborhood sampling.

Currently needs some debugging.

merge after 2150

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #2156
@rapids-bot rapids-bot bot requested review from a team as code owners March 29, 2022 20:48
This PR wraps the MG C++ implementation of HITS following the pylibcugraph API
Awaiting MG support to the C API

closes #2026

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Don Acosta (https://github.com/acostadon)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2088
@rapids-bot rapids-bot bot requested a review from a team as a code owner March 30, 2022 01:19
acostadon and others added 2 commits March 30, 2022 14:25
…lgos (#2099)

Code to inherit all of networkx graph then call cugraph pagerank with just an import change. 
This was originally going to do bfs first but pargerank was considered a more useful first algorithm.

Authors:
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)

URL: #2099
…sting coverage (#2120)

This PR was initially created because of two issues:
1. The pylibcugraph and cugraphs APIs differed from C++ and C because a compress flag was reinterpreted into a padding flag
2. Because of a renumbering bug, edges and vertices are not being renumbered correctly, causing multiple vertices and edges to be potentially identified as the same
3. Because of a type mismatching bug, `start_vertices` would yield garbage values and capture only half of the paths when using int64 values for vertices (this was initially thought to be a padding bug)

What this PR does to address each:
1. Renamed the `use_padding` flag to `compress_result` to be inline with libcugraph. If a user desires to enforce padding to keep track of paths via formula, one would set `compress_result=False` (use_padding=True)
2. `random_walks.cpp` now unrenumbers local vertex ids for use with pylibcugraph and cugraph
3. node2vec now works with the requirement of using `int32` only for graph vertices. Future plans include adding support to `int64` and other types.

Testing has been adapted from the C level, and further testing has been added to ensure invalid inputs are caught and results are expected with the new changes

Authors:
  - https://github.com/betochimas
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2120
CMake 3.23 has a bug that breaks our conda-build based builds in CI, this avoids that issue.

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #2176
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@790d93c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #2172   +/-   ##
===============================================
  Coverage                ?   70.82%           
===============================================
  Files                   ?      170           
  Lines                   ?    11036           
  Branches                ?        0           
===============================================
  Hits                    ?     7816           
  Misses                  ?     3220           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790d93c...38be932. Read the comment docs.

Closes #2108 when merged. Requires both #2088 and #2156 to be merged before, the former because this uses MGGraph, and the later because of the C implementation of neighborhood sampling.

Authors:
  - https://github.com/betochimas
  - Joseph Nke (https://github.com/jnke2016)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Don Acosta (https://github.com/acostadon)
  - Rick Ratzel (https://github.com/rlratzel)
  - Joseph Nke (https://github.com/jnke2016)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #2118
@sevagh sevagh merged commit b259a87 into branch-22.06 Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants