Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary host barrier synchronization #1917

Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Oct 29, 2021

This PR pulls updates from #1916. Better be reviewed after #1916 gets merged.

  • Remove unnecessary host barrier synchronization.

@seunghwak seunghwak requested a review from a team as a code owner October 29, 2021 20:53
@seunghwak seunghwak self-assigned this Oct 29, 2021
@seunghwak seunghwak added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function multi-GPU non-breaking Non-breaking change labels Oct 29, 2021
@seunghwak seunghwak added this to the 21.12 milestone Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@8624630). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ac76334 differs from pull request most recent head 8ea34f7. Consider uploading reports for the commit 8ea34f7 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1917   +/-   ##
===============================================
  Coverage                ?   70.30%           
===============================================
  Files                   ?      143           
  Lines                   ?     8863           
  Branches                ?        0           
===============================================
  Hits                    ?     6231           
  Misses                  ?     2632           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8624630...8ea34f7. Read the comment docs.

@seunghwak seunghwak added 3 - Ready for Review and removed DO NOT MERGE Hold off on merging; see PR for details labels Nov 2, 2021
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d1e504a into rapidsai:branch-21.12 Nov 3, 2021
rapids-bot bot pushed a commit that referenced this pull request Nov 9, 2021
…ll and P is large (#1919)

This PR pulls updates from #1916 & #1917. Better be reviewed after #1916 &#1917 gets merged.

(key, value) pairs are still disabled (by setting the threshold value to 0) as this has performance overhead and no clear benefit in analyzing larger graphs up to 32 GPUs (unless we artificially tweak 2D partitioning of GPUs). The threshold value needs to be adjusted with larger scale testing later.

- [x] Update copy_v_transform_reduce_in_out_nbr to use minor_properties_t as a temporary buffer.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1919
@seunghwak seunghwak deleted the enh_remove_unnecessary_barrier branch January 27, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants