Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce MNMG memory requirements #1916

Merged
merged 7 commits into from
Nov 2, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Oct 29, 2021

  • Add overflow check for vertex_t & edge_t in construct_edgelist
  • Update CUGRAPH_MG_TEST_PROGRAM_MAIN() to work with multiple nodes.
  • Memory requirement optimizations

@seunghwak seunghwak requested a review from a team as a code owner October 29, 2021 19:25
@seunghwak seunghwak self-assigned this Oct 29, 2021
@seunghwak seunghwak added this to the 21.12 milestone Oct 29, 2021
@seunghwak seunghwak added improvement Improvement / enhancement to an existing function multi-GPU non-breaking Non-breaking change labels Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@285ffc0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1916   +/-   ##
===============================================
  Coverage                ?   70.13%           
===============================================
  Files                   ?      143           
  Lines                   ?     8812           
  Branches                ?        0           
===============================================
  Hits                    ?     6180           
  Misses                  ?     2632           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285ffc0...da39f24. Read the comment docs.

Copy link
Collaborator

@kaatish kaatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue this PR could be connected to?

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8624630 into rapidsai:branch-21.12 Nov 2, 2021
rapids-bot bot pushed a commit that referenced this pull request Nov 3, 2021
This PR pulls updates from #1916. Better be reviewed after #1916 gets merged.

- [x] Remove unnecessary host barrier synchronization.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1917
rapids-bot bot pushed a commit that referenced this pull request Nov 9, 2021
…ll and P is large (#1919)

This PR pulls updates from #1916 & #1917. Better be reviewed after #1916 &#1917 gets merged.

(key, value) pairs are still disabled (by setting the threshold value to 0) as this has performance overhead and no clear benefit in analyzing larger graphs up to 32 GPUs (unless we artificially tweak 2D partitioning of GPUs). The threshold value needs to be adjusted with larger scale testing later.

- [x] Update copy_v_transform_reduce_in_out_nbr to use minor_properties_t as a temporary buffer.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants