Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cudf java build error. #9958

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

firestarman
Copy link
Contributor

@firestarman firestarman commented Dec 28, 2021

cudf Java build is broken by #9942. So update the hash JNI accordingly.

Signed-off-by: Firestarman [email protected]

This is caused by the change in rapidsai#9942.

Signed-off-by: Firestarman <[email protected]>
@firestarman firestarman requested a review from a team as a code owner December 28, 2021 02:43
@github-actions github-actions bot added the Java Affects Java cuDF API. label Dec 28, 2021
@firestarman firestarman added bug Something isn't working non-breaking Non-breaking change labels Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #9958 (dcd8753) into branch-22.02 (bf7f7be) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9958      +/-   ##
================================================
+ Coverage         10.37%   10.40%   +0.03%     
================================================
  Files               119      119              
  Lines             20115    20511     +396     
================================================
+ Hits               2086     2134      +48     
- Misses            18029    18377     +348     
Impacted Files Coverage Δ
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7f7be...dcd8753. Read the comment docs.

@sperlingxx
Copy link
Contributor

LGTM! Thanks for the fix.

@sperlingxx
Copy link
Contributor

rerun tests

@firestarman firestarman added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 28, 2021
@firestarman
Copy link
Contributor Author

rerun tests

@firestarman
Copy link
Contributor Author

java build failed in CI, seems to be related to conda libraries installation.

16:58:49 Solving environment: ...working... Build timed out (after 40 minutes). Marking the build as failed.
16:58:50 Build was aborted
16:58:50 Recording test results
16:58:51 [Checks API] No suitable checks publisher found.
16:58:51 [Set GitHub commit status (universal)] ERROR on repos 

@firestarman
Copy link
Contributor Author

firestarman commented Dec 29, 2021

I am going to merge this to unblock the cudf Java nightly build.
The failure in gpuci/java is not relevant.

@firestarman
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 67c925c into rapidsai:branch-22.02 Dec 29, 2021
@firestarman firestarman deleted the fix-hash branch December 29, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants