Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated method Series.hash_encode. #9942

Merged
merged 4 commits into from
Dec 23, 2021
Merged

Remove deprecated method Series.hash_encode. #9942

merged 4 commits into from
Dec 23, 2021

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 21, 2021 •
edited
Loading

This PR removes the deprecated method Series.hash_encode. Resolves #9475. Follows up on #9457, #9381.

This PR also removes libcudf code paths used solely for this Python method.

Users may replace code like series.hash_encode(stop, use_name=False) with series.hash_values(method="murmur3") % stop.

@bdice bdice added tech debt breaking Breaking change labels Dec 21, 2021
@bdice bdice self-assigned this Dec 21, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 21, 2021
@bdice bdice added improvement Improvement / enhancement to an existing function and removed Python Affects Python cuDF API. labels Dec 21, 2021
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Dec 21, 2021
@bdice bdice changed the title Remove Series.hash_encode. Remove deprecated method Series.hash_encode. Dec 21, 2021
@bdice bdice marked this pull request as ready for review December 21, 2021 20:58
@bdice bdice requested review from a team as code owners December 21, 2021 20:58
codereport
codereport approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5:1 delete ratio! Woo 🔥

@bdice bdice added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #9942 (b446cd5) into branch-22.02 (04f4219) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head b446cd5 differs from pull request most recent head 383f66c. Consider uploading reports for the commit 383f66c to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9942      +/-   ##
================================================
+ Coverage         10.37%   10.41%   +0.04%     
================================================
  Files               119      119              
  Lines             20111    20488     +377     
================================================
+ Hits               2086     2134      +48     
- Misses            18025    18354     +329
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <ø> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f4219...383f66c. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Dec 23, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c99a37f into rapidsai:branch-22.02 Dec 23, 2021
@bdice bdice deleted the remove-series-hash_encode branch December 23, 2021 23:40
firestarman added a commit to firestarman/cudf that referenced this pull request Dec 28, 2021
@firestarman
Fix cudf java build error.
dcd8753 
This is caused by the change in rapidsai#9942.

Signed-off-by: Firestarman <[email protected]>
@firestarman firestarman mentioned this pull request Dec 28, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Dec 29, 2021
@firestarman
Fix cudf java build error. (#9958)
67c925c 
cudf Java build is broken by #9942. So update the `hash` JNI accordingly.

Signed-off-by: Firestarman <[email protected]>

Authors:
  - Liangcai Li (https://github.com/firestarman)

Approvers:
  - Gary Shen (https://github.com/GaryShen2008)

URL: #9958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@codereport codereport codereport approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@marlenezw marlenezw Awaiting requested review from marlenezw marlenezw is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPRECATION] Remove Series.hash_encode
3 participants
@bdice @codereport @rgsl888prabhu