Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated method DataFrame.hash_columns. #9943

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 21, 2021

This PR removes the deprecated method DataFrame.hash_columns. Users can replace existing calls like df.hash_columns(columns, method) with df[columns].hash_values(method). Resolves #9503, follows up on #9458.

@bdice bdice added breaking Breaking change improvement Improvement / enhancement to an existing function tech debt labels Dec 21, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 21, 2021
@bdice bdice self-assigned this Dec 21, 2021
@bdice bdice removed the tech debt label Dec 21, 2021
@bdice bdice marked this pull request as ready for review December 21, 2021 20:58
@bdice bdice requested a review from a team as a code owner December 21, 2021 20:58
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #9943 (c0cd84d) into branch-22.02 (04f4219) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head c0cd84d differs from pull request most recent head 006ac25. Consider uploading reports for the commit 006ac25 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9943      +/-   ##
================================================
+ Coverage         10.37%   10.41%   +0.03%     
================================================
  Files               119      119              
  Lines             20111    20499     +388     
================================================
+ Hits               2086     2134      +48     
- Misses            18025    18365     +340     
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 0.00% <ø> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f4219...006ac25. Read the comment docs.

Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdice
Copy link
Contributor Author

bdice commented Jan 4, 2022

This is a straightforward removal of code, so I'm going to merge with one approval.

@gpucibot merge

@bdice
Copy link
Contributor Author

bdice commented Jan 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d69ea61 into rapidsai:branch-22.02 Jan 4, 2022
@bdice bdice deleted the remove-dataframe-hash_columns branch January 4, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEPRECATION] Remove DataFrame.hash_columns
2 participants