Implement DataFrame.hash_values, deprecate DataFrame.hash_columns. #9458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9458 +/- ##
================================================
- Coverage 10.79% 10.65% -0.14%
================================================
Files 116 117 +1
Lines 18869 19759 +890
================================================
+ Hits 2036 2106 +70
- Misses 16833 17653 +820
Continue to review full report at Codecov.
|
|
@skirui-source Good catch! I have now added tests. The tests for |
galipremsagar
requested changes
Oct 19, 2021
galipremsagar
approved these changes
Oct 19, 2021
skirui-source
approved these changes
Oct 19, 2021
rgsl888prabhu
approved these changes
Oct 19, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 4, 2022
This PR removes the deprecated method `DataFrame.hash_columns`. Users can replace existing calls like `df.hash_columns(columns, method)` with `df[columns].hash_values(method)`. Resolves #9503, follows up on #9458. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - https://github.com/brandon-b-miller URL: #9943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
DataFrame.hash_values, which will replaceDataFrame.hash_columns(which is deprecated in this PR). This proposal was discussed offline with @vyasr and in the weekly cuDF Python dev meeting.This unifies the method name and signature for
Series.hash_valuesandDataFrame.hash_values, enabling future internal refactoring by moving the method's implementation to theFrameclass (though I'm waiting for the removal ofSeries.hash_encodeto follow up on this so it can be done in a single pass, see #9381 and #9457).