Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build-time publish step to cpu build script #9927

Merged
merged 38 commits into from
Jan 10, 2022
Merged

Add build-time publish step to cpu build script #9927

merged 38 commits into from
Jan 10, 2022

Conversation

davidwendt
Copy link
Contributor

Follow on to #9631. This copies the generated BuildMetrics.html to the ci/cpu/build.sh to make it available for the Jenkins publishHtml publisher.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2021
@davidwendt davidwendt self-assigned this Dec 17, 2021
@github-actions github-actions bot added gpuCI and removed libcudf Affects libcudf (C++/CUDA) code. labels Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited
Loading

Codecov Report

Merging #9927 (6e1b79b) into branch-22.02 (de8c0b8) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9927      +/-   ##
================================================
+ Coverage         10.41%   10.45%   +0.03%     
================================================
  Files               119      119              
  Lines             20023    20417     +394     
================================================
+ Hits               2086     2134      +48     
- Misses            17937    18283     +346
Impacted Files Coverage Δ
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8c0b8...6e1b79b. Read the comment docs.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 18, 2021
karthikeyann
karthikeyann reviewed Dec 19, 2021
View reviewed changes
cpp/scripts/sort_ninja_log.py
@@ -88,21 +88,42 @@
elif output_fmt == "html":
# output results in HTML format
print("<html><head><title>Sorted Ninja Build Times</title>")
print("<style>", "table, th, td { border:1px solid black; }", "</style>")
# Note: Jenkins does not support style defined in the html
# https://www.jenkins.io/doc/book/security/configuring-content-security-policy/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. This is why fancy tables doesn't work in html page! 😢

@davidwendt
Copy link
Contributor Author

Here is a report where most of the files were recompiled (see cache-hit percentage):
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/6805/Build_20Metrics_20Report/
(this one is missing the libcudf.so size added latter in a PR commit)

Here is another where from this same PR where most of the files came from the ccache.
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/6823/Build_20Metrics_20Report/

These are accessible from the gpuCI/cudf/build/cuda/11.5 Details link example1 example2
Where the new Build Metrics Report link appears in the left column.

image

@davidwendt davidwendt marked this pull request as ready for review January 5, 2022 17:56
@davidwendt davidwendt requested review from a team as code owners January 5, 2022 17:56
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 5, 2022
robertmaynard
robertmaynard reviewed Jan 5, 2022
View reviewed changes
build.sh Show resolved Hide resolved
robertmaynard
robertmaynard reviewed Jan 6, 2022
View reviewed changes
build.sh Show resolved Hide resolved
@davidwendt davidwendt added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 7, 2022
@github-actions github-actions bot added the conda label Jan 7, 2022
@davidwendt davidwendt removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 7, 2022
karthikeyann
karthikeyann approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for doing this!

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b7b87fb into rapidsai:branch-22.02 Jan 10, 2022
@davidwendt davidwendt deleted the build-time-publish-html branch January 10, 2022 14:47
@GregoryKimball GregoryKimball mentioned this pull request Jun 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @robertmaynard @karthikeyann @jjacobelli