Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility to format ninja-log build times #9631

Merged
merged 58 commits into from
Dec 14, 2021
Merged

Add utility to format ninja-log build times #9631

merged 58 commits into from
Dec 14, 2021

Conversation

davidwendt
Copy link
Contributor

Reference: https://github.com/rapidsai/ops/issues/1896

Generate build times log from formatted, sorted .ninja_log file.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 8, 2021
@davidwendt davidwendt self-assigned this Nov 8, 2021
@github-actions github-actions bot added gpuCI and removed libcudf Affects libcudf (C++/CUDA) code. labels Nov 8, 2021
@davidwendt
Copy link
Contributor Author

rerun tests

@davidwendt
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #9631 (1d1b8a0) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9631      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20473     +168     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18339     +164
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b299a...1d1b8a0. Read the comment docs.

karthikeyann
karthikeyann reviewed Nov 17, 2021
View reviewed changes
build.sh Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot added the CMake CMake build issue label Dec 9, 2021
@davidwendt davidwendt requested a review from a team as a code owner December 9, 2021 13:52
robertmaynard
robertmaynard requested changes Dec 9, 2021
View reviewed changes
build.sh Outdated Show resolved Hide resolved
robertmaynard
robertmaynard approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.sh changes LGTM

@github-actions github-actions bot removed the CMake CMake build issue label Dec 10, 2021
karthikeyann
karthikeyann approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cpp/scripts/sort_ninja_log.py Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7a23f1a into rapidsai:branch-22.02 Dec 14, 2021
@davidwendt davidwendt deleted the build-format-ninja-log branch December 14, 2021 20:29
@davidwendt davidwendt mentioned this pull request Dec 17, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 10, 2022
@davidwendt
Add build-time publish step to cpu build script (#9927)
b7b87fb 
Follow on to #9631. This copies the generated BuildMetrics.html to the ci/cpu/build.sh to make it available for the Jenkins publishHtml publisher.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Karthikeyan (https://github.com/karthikeyann)
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: #9927
@vyasr vyasr mentioned this pull request Oct 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @robertmaynard @karthikeyann @ajschmidt8