Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memcheck error in ORC writer #9896

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Dec 14, 2021

Follow up of #9808
Skips some kernels when input columns are empty to avoid OOB memory access.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Dec 14, 2021
@vuule vuule self-assigned this Dec 14, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #9896 (a83b31a) into branch-22.02 (967a333) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9896      +/-   ##
================================================
- Coverage         10.49%   10.37%   -0.12%     
================================================
  Files               119      119              
  Lines             20305    20105     -200     
================================================
- Hits               2130     2086      -44     
+ Misses            18175    18019     -156     
Impacted Files Coverage Δ
python/custreamz/custreamz/tests/conftest.py 71.42% <0.00%> (-7.15%) ⬇️
python/custreamz/custreamz/tests/test_kafka.py 35.71% <0.00%> (-7.15%) ⬇️
...ython/custreamz/custreamz/tests/test_dataframes.py 96.97% <0.00%> (-2.42%) ⬇️
python/dask_cudf/dask_cudf/backends.py 82.53% <0.00%> (-0.61%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/dask_cudf/dask_cudf/accessors.py 92.00% <0.00%> (-0.31%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_s3.py 95.77% <0.00%> (-0.18%) ⬇️
python/dask_cudf/dask_cudf/io/parquet.py 93.46% <0.00%> (-0.17%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335862b...a83b31a. Read the comment docs.

@vuule vuule marked this pull request as ready for review December 14, 2021 18:59
@vuule vuule requested a review from a team as a code owner December 14, 2021 18:59
@vuule vuule requested review from cwharris and davidwendt December 14, 2021 18:59
@vuule
Copy link
Contributor Author

vuule commented Dec 14, 2021

rerun tests

@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Dec 14, 2021
@vuule
Copy link
Contributor Author

vuule commented Dec 14, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 61794aa into rapidsai:branch-22.02 Dec 14, 2021
@vuule vuule deleted the bug-orc-writer-memcheck branch December 14, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants