-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a memcheck error in ORC writer #9896
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-22.02
from
vuule:bug-orc-writer-memcheck
Dec 14, 2021
Merged
Fix a memcheck error in ORC writer #9896
rapids-bot
merged 2 commits into
rapidsai:branch-22.02
from
vuule:bug-orc-writer-memcheck
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
bug
Something isn't working
cuIO
cuIO issue
non-breaking
Non-breaking change
labels
Dec 14, 2021
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9896 +/- ##
================================================
- Coverage 10.49% 10.37% -0.12%
================================================
Files 119 119
Lines 20305 20105 -200
================================================
- Hits 2130 2086 -44
+ Misses 18175 18019 -156
Continue to review full report at Codecov.
|
bdice
reviewed
Dec 14, 2021
devavret
approved these changes
Dec 14, 2021
ttnghia
approved these changes
Dec 14, 2021
davidwendt
approved these changes
Dec 14, 2021
Co-authored-by: Bradley Dice <[email protected]>
rerun tests |
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
cuIO
cuIO issue
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #9808
Skips some kernels when input columns are empty to avoid OOB memory access.