Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for map column metadata handling in ORC writer #9852

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Add test for map column metadata handling in ORC writer #9852

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d11beeb
add missing test for #9782
vuule Dec 7, 2021
a22955f
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
vuule Dec 8, 2021
dcbb1cd
add aliases; other clean up in tests
vuule Dec 8, 2021
108216a
CMake style !?
vuule Dec 9, 2021
d6d55dd
Merge branch 'branch-22.02' of https://github.com/rapidsai/cudf into …
vuule Dec 17, 2021
6b6e1c8
null_at
vuule Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/cmake/thirdparty/get_dlpack.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ function(find_and_configure_dlpack VERSION)
dlpack ${VERSION}
GIT_REPOSITORY https://github.com/dmlc/dlpack.git
GIT_TAG v${VERSION}
GIT_SHALLOW TRUE DOWNLOAD_ONLY TRUE
GIT_SHALLOW TRUE
DOWNLOAD_ONLY TRUE
OPTIONS "BUILD_MOCK OFF"
)

Expand Down
3 changes: 2 additions & 1 deletion cpp/cmake/thirdparty/get_jitify.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ function(find_and_configure_jitify)
jitify 2.0.0
GIT_REPOSITORY https://github.com/rapidsai/jitify.git
GIT_TAG cudf_0.19
GIT_SHALLOW TRUE DOWNLOAD_ONLY TRUE
GIT_SHALLOW TRUE
DOWNLOAD_ONLY TRUE
)
set(JITIFY_INCLUDE_DIR
"${jitify_SOURCE_DIR}"
Expand Down
5 changes: 3 additions & 2 deletions cpp/cmake/thirdparty/get_libcudacxx.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ function(find_and_configure_libcudacxx)
include(${rapids-cmake-dir}/cpm/libcudacxx.cmake)

rapids_cpm_libcudacxx(
BUILD_EXPORT_SET cudf-exports INSTALL_EXPORT_SET cudf-exports PATCH_COMMAND patch
--reject-file=- -p1 -N < ${CUDF_SOURCE_DIR}/cmake/libcudacxx.patch || true
BUILD_EXPORT_SET cudf-exports
INSTALL_EXPORT_SET cudf-exports PATCH_COMMAND patch --reject-file=- -p1 -N <
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the syntax used in cmake files. Should there be a \ at the end to indicate continuation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, this is a style fix when the checker version changed. Merged trunk so these changes are gone from the PR.

${CUDF_SOURCE_DIR}/cmake/libcudacxx.patch || true
)

set(LIBCUDACXX_INCLUDE_DIR
Expand Down
Loading