Add test for map column metadata handling in ORC writer #9852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9852 +/- ##
================================================
- Coverage 10.49% 10.40% -0.09%
================================================
Files 119 119
Lines 20305 20503 +198
================================================
+ Hits 2130 2134 +4
- Misses 18175 18369 +194
Continue to review full report at Codecov.
|
ttnghia
reviewed
Dec 8, 2021
ttnghia
approved these changes
Dec 8, 2021
mythrocks
reviewed
Dec 16, 2021
| @@ -41,6 +42,22 @@ using column_wrapper = | |||
| typename std::conditional<std::is_same_v<T, cudf::string_view>, | |||
There was a problem hiding this comment.
Oh, this is clever. Need to remember this one.
mythrocks
reviewed
Dec 16, 2021
mythrocks
reviewed
Dec 16, 2021
mythrocks
reviewed
Dec 16, 2021
| BUILD_EXPORT_SET cudf-exports INSTALL_EXPORT_SET cudf-exports PATCH_COMMAND patch | ||
| --reject-file=- -p1 -N < ${CUDF_SOURCE_DIR}/cmake/libcudacxx.patch || true | ||
| BUILD_EXPORT_SET cudf-exports | ||
| INSTALL_EXPORT_SET cudf-exports PATCH_COMMAND patch --reject-file=- -p1 -N < |
There was a problem hiding this comment.
I'm not familiar with the syntax used in cmake files. Should there be a \ at the end to indicate continuation?
There was a problem hiding this comment.
No idea, this is a style fix when the checker version changed. Merged trunk so these changes are gone from the PR.
mythrocks
approved these changes
Dec 16, 2021
…missing-orc-map-test
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands existing ORC test to cover the fix merged in #9782
Test now has struct column nested in a map column, so that the propagation of names of the leaf columns (struct column field names in ORC) can be tested. The test segfaults without the fix in #9782