Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Allow cast decimal128 to string and add tests #9756

Merged
merged 2 commits into from
Dec 1, 2021
Merged

[Java] Allow cast decimal128 to string and add tests #9756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e4b79b
Allow decimal128 cast and add tests
razajafri Nov 23, 2021
f0c8666
fixed format
razajafri Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java/src/main/native/src/ColumnViewJni.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,8 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_castTo(JNIEnv *env, jclas
case cudf::type_id::INT64:
case cudf::type_id::UINT64: result = cudf::strings::from_integers(*column); break;
case cudf::type_id::DECIMAL32:
case cudf::type_id::DECIMAL64: result = cudf::strings::from_fixed_point(*column); break;
case cudf::type_id::DECIMAL64:
case cudf::type_id::DECIMAL128: result = cudf::strings::from_fixed_point(*column); break;
default: JNI_THROW_NEW(env, "java/lang/IllegalArgumentException", "Invalid data type", 0);
}
} else if (column->type().id() == cudf::type_id::STRING) {
Expand Down
16 changes: 16 additions & 0 deletions java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3370,6 +3370,22 @@ void testFixedWidthCast() {
}
}

@Test
void testCastBigDecimalToString() {
BigDecimal[] bigValues = {new BigDecimal("923121331938210123.321"),
new BigDecimal("9223372036854775808.191"),
new BigDecimal("9328323982309091029831.002")
};

try (ColumnVector cv = ColumnVector.fromDecimals(bigValues);
ColumnVector values = cv.castTo(DType.STRING);
ColumnVector expected = ColumnVector.fromStrings("923121331938210123.321",
"9223372036854775808.191",
"9328323982309091029831.002")) {
assertColumnsAreEqual(expected, values);
}
}

@Test
void testCastStringToBigDecimal() {
String[] bigValues = {"923121331938210123.321",
Expand Down