Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Allow cast decimal128 to string and add tests #9756

Merged
merged 2 commits into from
Dec 1, 2021
Merged

[Java] Allow cast decimal128 to string and add tests #9756

merged 2 commits into from
Dec 1, 2021

Conversation

razajafri
Copy link
Contributor

Small PR that enables Decimal128 cast

@razajafri razajafri added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 23, 2021
@razajafri razajafri self-assigned this Nov 23, 2021
@razajafri razajafri requested a review from a team as a code owner November 23, 2021 00:38
@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #9756 (f0c8666) into branch-22.02 (967a333) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9756      +/-   ##
================================================
- Coverage         10.49%   10.12%   -0.37%     
================================================
  Files               119      119              
  Lines             20305    21248     +943     
================================================
+ Hits               2130     2151      +21     
- Misses            18175    19097     +922
Impacted Files Coverage Δ
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/string.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85df759...f0c8666. Read the comment docs.

@razajafri
Copy link
Contributor Author

rerun tests

1 similar comment
@razajafri
Copy link
Contributor Author

rerun tests

@razajafri
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d8a8e5 into rapidsai:branch-22.02 Dec 1, 2021
@razajafri razajafri deleted the CUDF-dec-128-string branch December 1, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@razajafri razajafri

Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razajafri @jlowe