Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cuda version in local build #9736

Merged
merged 2 commits into from
Nov 23, 2021
Merged

update cuda version in local build #9736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41ba41b
update cuda, ubuntu version
karthikeyann Nov 19, 2021
cc5f75e
update default docker image tags
karthikeyann Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ci/local/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ Build and test your local repository using a base gpuCI Docker image
where:
-H Show this help text
-r Path to repository (defaults to working directory)
-i Use Docker image (default is gpuci/rapidsai:${NIGHTLY_VERSION}-cuda10.1-devel-ubuntu16.04-py3.7)
-i Use Docker image (default is gpuci/rapidsai:${NIGHTLY_VERSION}-cuda11.5-devel-ubuntu20.04-py3.8)
Copy link
Contributor

@bdice bdice Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between developing from gpuci/rapidsai and rapidsai/rapidsai-dev? It sounds like both are development containers, but I am not familiar with the differences or how to locate that information as a user/developer.

In general, we have a lot of similarly-named containers and I don't know how to identify the purpose of each. The DockerHub page for the gpuci/rapidsai container (https://hub.docker.com/r/gpuci/rapidsai) is slim on docs, but I don't know of a better source for this kind of information. The rapidsai/rapidsai-dev container has more documentation, which I found very valuable. Should this be raised as a separate issue?

Copy link
Contributor Author

@karthikeyann karthikeyann Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuci images are development images for continuous integration(CI).
gpuci docker images are supposed to be same environment as CI. If you want to run CI tests and build locally, these images could be used. These images are available during development cycle of each version of rapidsai.

rapidsai/rapidsai images are not supposed be used for development of rapidsai library itself. It is for development using rapidsai libraries. It contains rapidsai libraries installed. It's available after the each rapidsai release. Not during the development.

rapidsai dockers have 3 flavors: Base, Runtime, Devel. Devel is supposed to be for development using rapidsai libraries. Devel images are not upto date (last updated 2 years ago)

The RAPIDS images are based on nvidia/cuda, and are intended to be drop-in replacements for the corresponding CUDA images in order to make it easy to add RAPIDS libraries while maintaining support for existing CUDA applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the difference between gpuci/rapidsai and rapidsai/rapidsai-dev. It seems like they moved all devel containers from rapidsai to rapidsai-dev.

-s Skip building and testing and start an interactive shell in a container of the Docker image
```

Example Usage:
`bash build.sh -r ~/rapids/cudf -i gpuci/rapidsai:0.16-cuda10.2-devel-ubuntu16.04-py3.7`
`bash build.sh -r ~/rapids/cudf -i gpuci/rapidsai:22.02-cuda11.5-devel-ubuntu20.04-py3.8`

For a full list of available gpuCI docker images, visit our [DockerHub](https://hub.docker.com/r/gpuci/rapidsai/tags) page.

Expand All @@ -42,7 +42,7 @@ There are some caveats to be aware of when using this script, especially if you

### Docker Image Build Repository

The docker image will generate build artifacts in a folder on your machine located in the `root` directory of the repository you passed to the script. For the above example, the directory is named `~/rapids/cudf/build_rapidsai_cuda10.1-ubuntu16.04-py3.7/`. Feel free to remove this directory after the script is finished.
The docker image will generate build artifacts in a folder on your machine located in the `root` directory of the repository you passed to the script. For the above example, the directory is named `~/rapids/cudf/build_rapidsai_cuda11.5-ubuntu20.04-py3.8/`. Feel free to remove this directory after the script is finished.

*Note*: The script *will not* override your local build repository. Your local environment stays in tact.

Expand Down
2 changes: 1 addition & 1 deletion ci/local/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
GIT_DESCRIBE_TAG=`git describe --tags`
MINOR_VERSION=`echo $GIT_DESCRIBE_TAG | grep -o -E '([0-9]+\.[0-9]+)'`

DOCKER_IMAGE="gpuci/rapidsai:${MINOR_VERSION}-cuda11.0-devel-ubuntu18.04-py3.7"
DOCKER_IMAGE="gpuci/rapidsai:${MINOR_VERSION}-cuda11.5-devel-ubuntu20.04-py3.8"
REPO_PATH=${PWD}
RAPIDS_DIR_IN_CONTAINER="/rapids"
CPP_BUILD_DIR="cpp/build"
Expand Down