Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cuda version in local build #9736

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

karthikeyann
Copy link
Contributor

update cuda, ubuntu, python versions in local build using gpuci docker image.

@karthikeyann karthikeyann requested a review from a team as a code owner November 19, 2021 16:36
@github-actions github-actions bot added the gpuCI label Nov 19, 2021
@karthikeyann karthikeyann added non-breaking Non-breaking change tech debt doc Documentation labels Nov 19, 2021
@karthikeyann
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #9736 (cc5f75e) into branch-22.02 (967a333) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-22.02    #9736   +/-   ##
=============================================
  Coverage         10.49%   10.49%           
=============================================
  Files               119      119           
  Lines             20305    20305           
=============================================
  Hits               2130     2130           
  Misses            18175    18175           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1f1e7...cc5f75e. Read the comment docs.

@@ -18,12 +18,12 @@ Build and test your local repository using a base gpuCI Docker image
where:
-H Show this help text
-r Path to repository (defaults to working directory)
-i Use Docker image (default is gpuci/rapidsai:${NIGHTLY_VERSION}-cuda10.1-devel-ubuntu16.04-py3.7)
-i Use Docker image (default is gpuci/rapidsai:${NIGHTLY_VERSION}-cuda11.5-devel-ubuntu20.04-py3.8)
Copy link
Contributor

@bdice bdice Nov 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between developing from gpuci/rapidsai and rapidsai/rapidsai-dev? It sounds like both are development containers, but I am not familiar with the differences or how to locate that information as a user/developer.

In general, we have a lot of similarly-named containers and I don't know how to identify the purpose of each. The DockerHub page for the gpuci/rapidsai container (https://hub.docker.com/r/gpuci/rapidsai) is slim on docs, but I don't know of a better source for this kind of information. The rapidsai/rapidsai-dev container has more documentation, which I found very valuable. Should this be raised as a separate issue?

Copy link
Contributor Author

@karthikeyann karthikeyann Nov 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpuci images are development images for continuous integration(CI).
gpuci docker images are supposed to be same environment as CI. If you want to run CI tests and build locally, these images could be used. These images are available during development cycle of each version of rapidsai.

rapidsai/rapidsai images are not supposed be used for development of rapidsai library itself. It is for development using rapidsai libraries. It contains rapidsai libraries installed. It's available after the each rapidsai release. Not during the development.

rapidsai dockers have 3 flavors: Base, Runtime, Devel. Devel is supposed to be for development using rapidsai libraries. Devel images are not upto date (last updated 2 years ago)

The RAPIDS images are based on nvidia/cuda, and are intended to be drop-in replacements for the corresponding CUDA images in order to make it easy to add RAPIDS libraries while maintaining support for existing CUDA applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the difference between gpuci/rapidsai and rapidsai/rapidsai-dev. It seems like they moved all devel containers from rapidsai to rapidsai-dev.

@karthikeyann karthikeyann requested a review from bdice November 22, 2021 07:03
@karthikeyann
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d1811b5 into branch-22.02 Nov 23, 2021
@karthikeyann karthikeyann deleted the karthikeyann-patch-2 branch May 14, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants