Use stream allocator adaptor for hash join table #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
3 - Ready for Review
|
Current CMake changes are dedicated to CI tests only. Will update the main branch git tag once NVIDIA/cuCollections#119 is merged. |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9704 +/- ##
================================================
- Coverage 10.49% 10.44% -0.05%
================================================
Files 119 119
Lines 20305 20422 +117
================================================
+ Hits 2130 2133 +3
- Misses 18175 18289 +114
Continue to review full report at Codecov.
|
harrism
changed the title
karthikeyann
requested changes
Nov 22, 2021
jrhemstad
reviewed
Dec 2, 2021
jrhemstad
added
0 - Waiting on Author
PointKernel
removed
the
0 - Waiting on Author
jrhemstad
added
the
5 - Ready to Merge
harrism
added
3 - Ready for Review
harrism
requested changes
Dec 3, 2021
| @@ -21,7 +21,7 @@ function(find_and_configure_cucollections) | |||
| cuco 0.0 | |||
| GLOBAL_TARGETS cuco::cuco | |||
| CPM_ARGS GITHUB_REPOSITORY NVIDIA/cuCollections | |||
| GIT_TAG f0eecb203590f1f4ac4a9f1700229f4434ac64dc | |||
| GIT_TAG 6433e8ad7571f14cc5384051b049029c60dd1ce0 | |||
There was a problem hiding this comment.
If the dependency PR is already merged, shouldn't this GIT_TAG be removed and just depend on a release branch?
There was a problem hiding this comment.
cuco doesn't have a release yet thus we choose to fetch a specific commit instead of the main branch (dev).
jrhemstad
added
5 - Ready to Merge
|
@harrism @karthikeyann please re-review. |
karthikeyann
approved these changes
Dec 6, 2021
harrism
approved these changes
Dec 6, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
The `concurrent_unordered_multimap` is no longer used in libcudf. It has been replaced by `cuco::static_multimap`. The majority of the refactoring was done in PRs #8934 and #9704. A similar effort is in progress for `concurrent_unordered_map` and `cuco::static_map` in #9666 (and may depend on porting some optimizations from libcudf to cuco -- need to look into this before doing a direct replacement). This partially resolves issue #10401. cc: @PointKernel @vyasr Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Vyas Ramasubramani (https://github.com/vyasr) - Jake Hemstad (https://github.com/jrhemstad) URL: #10642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on NVIDIA/cuCollections#119
This PR replaces the default hash join allocator with the corresponding
rmm::mr::stream_allocator_adaptor. It accommodates newcuco::allocatorAPIs that don't take stream as input argument.