Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concurrent_unordered_multimap. #10642

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 12, 2022

The concurrent_unordered_multimap is no longer used in libcudf. It has been replaced by cuco::static_multimap. The majority of the refactoring was done in PRs #8934 and #9704. A similar effort is in progress for concurrent_unordered_map and cuco::static_map in #9666 (and may depend on porting some optimizations from libcudf to cuco -- need to look into this before doing a direct replacement).

This partially resolves issue #10401.

cc: @PointKernel @vyasr

@bdice bdice added tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 12, 2022
@bdice bdice requested a review from a team as a code owner April 12, 2022 17:22
@bdice bdice self-assigned this Apr 12, 2022
@bdice bdice requested review from harrism and codereport April 12, 2022 17:22
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 12, 2022
@jrhemstad
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #10642 (df68de1) into branch-22.06 (3c13ef1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06   #10642      +/-   ##
================================================
+ Coverage         86.33%   86.37%   +0.04%     
================================================
  Files               140      140              
  Lines             22289    22290       +1     
================================================
+ Hits              19244    19254      +10     
+ Misses             3045     3036       -9     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/dataframe.py 93.59% <ø> (ø)
python/cudf/cudf/core/groupby/groupby.py 91.72% <ø> (+0.22%) ⬆️
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.28% <ø> (ø)
python/cudf/cudf/core/single_column_frame.py 96.45% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 59.83% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/column/lists.py 92.79% <100.00%> (+1.38%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8e92c...df68de1. Read the comment docs.

@bdice
Copy link
Contributor Author

bdice commented Apr 12, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8c825f5 into rapidsai:branch-22.06 Apr 12, 2022
@bdice bdice deleted the remove-concurrent-unordered-multimap branch April 19, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants