-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixed point to AllTypes in libcudf unit tests #9472
Add fixed point to AllTypes in libcudf unit tests #9472
Conversation
(this needs fix to scalar and device scalar) device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@codereport do
scalar_device_view.cuh
|
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9472 +/- ##
================================================
- Coverage 10.79% 10.66% -0.13%
================================================
Files 116 117 +1
Lines 18869 19755 +886
================================================
+ Hits 2036 2106 +70
- Misses 16833 17649 +816
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I would say don't change it. I definitely recall that I explicitly added the fixed_point_value() on the non device type, but I don't think we want't that on the device one. If there is a need down that line for some of the "missing" methods we can revisit it then. |
@gpucibot merge |
Fixes part of #9468
fixed_point_scalar
andfixed_point_scalar_device_view
.fixed_point_scalar::value()
(to avoidT{}
cast)