Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for fixed point in quantiles #9469

Open
karthikeyann opened this issue Oct 19, 2021 · 3 comments
Open

Add unit tests for fixed point in quantiles #9469

karthikeyann opened this issue Oct 19, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code. tests Unit testing for project

Comments

@karthikeyann
Copy link
Contributor

karthikeyann commented Oct 19, 2021 •
edited
Loading

Describe the bug
Quantiles support fixed point columns. but it is not tested in unit tests (both gtest and pytest).

Expected behavior
add unit tests for fixed_point in quantiles gtest

Additional context
#9468
While adding FixedPointTypes to cudf::test::AllTypes, QUANTILES_TEST (Failed).

[ FAILED ] QuantileUnsupportedTypesTest/10.TestZeroElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10>
[ FAILED ] QuantileUnsupportedTypesTest/10.TestOneElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10>
[ FAILED ] QuantileUnsupportedTypesTest/10.TestMultipleElements, where TypeParam = numeric::fixed_point<int, (numeric::Radix)10>
[ FAILED ] QuantileUnsupportedTypesTest/11.TestZeroElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>
[ FAILED ] QuantileUnsupportedTypesTest/11.TestOneElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>
[ FAILED ] QuantileUnsupportedTypesTest/11.TestMultipleElements, where TypeParam = numeric::fixed_point<long, (numeric::Radix)10>

6 FAILED TESTS
@karthikeyann karthikeyann mentioned this issue Oct 19, 2021
Closed
3 tasks
@karthikeyann karthikeyann changed the title QUANTILES_TEST Add unit tests for fixed point in quantiles Oct 19, 2021
@karthikeyann karthikeyann added Needs Triage Need team to review and classify bug Something isn't working tests Unit testing for project labels Oct 19, 2021
karthikeyann added a commit to karthikeyann/cudf that referenced this issue Oct 19, 2021
@karthikeyann
skip fixed point types in quantile test (will be fixed in rapidsai#9469)
83466f0
@beckernick beckernick added libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify labels Oct 25, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@karthikeyann karthikeyann added the good first issue Good for newcomers label Feb 24, 2022
@karthikeyann
Copy link
Contributor Author

still relevant and needs to be addressed.
Added "good first issue"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers libcudf Affects libcudf (C++/CUDA) code. tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karthikeyann @beckernick @GregoryKimball