-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIW] Miscellaneous documentation fixes to cudf
#9471
[REVIW] Miscellaneous documentation fixes to cudf
#9471
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9471 +/- ##
================================================
- Coverage 10.79% 10.65% -0.14%
================================================
Files 116 117 +1
Lines 18869 19760 +891
================================================
+ Hits 2036 2106 +70
- Misses 16833 17654 +821
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recently also noticed that the docstrings of rand_dataframe
in dataset_generator.py
is lacking description to list
dtype dtype_meta
. Specifically:
- lists_max_length
- nesting_max_depth
- value_type
Can you add them to this PR also as part of the doc fixes?
I think I'll need to be updating the docstrings of |
@gpucibot merge |
This PR:
.struct
accessorDecimal32Dtype