Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add struct generation support in datagenerator & fuzz tests #9180

Merged
merged 14 commits into from
Jan 20, 2022
Merged

[REVIEW] Add struct generation support in datagenerator & fuzz tests #9180

merged 14 commits into from
Jan 20, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 5, 2021 •
edited
Loading

Resolves: #7618

This PR adds struct dtype support in data-generator for fuzz-testing.

@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 5, 2021
@galipremsagar galipremsagar self-assigned this Sep 5, 2021
@codecov
Copy link

codecov bot commented Sep 5, 2021 •
edited
Loading

Codecov Report

Merging #9180 (a65d4be) into branch-22.02 (967a333) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9180      +/-   ##
================================================
- Coverage         10.49%   10.36%   -0.13%     
================================================
  Files               119      119              
  Lines             20305    20632     +327     
================================================
+ Hits               2130     2139       +9     
- Misses            18175    18493     +318
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/scalar.py 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd7dd2...a65d4be. Read the comment docs.

@galipremsagar galipremsagar changed the base branch from branch-21.10 to branch-21.12 October 5, 2021 16:21
@galipremsagar galipremsagar mentioned this pull request Oct 20, 2021
Merged
4 tasks
@galipremsagar galipremsagar mentioned this pull request Nov 8, 2021
Closed
2 tasks
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. labels Jan 19, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 19, 2022
@galipremsagar galipremsagar changed the base branch from branch-21.12 to 21.12 January 19, 2022 17:12
@galipremsagar galipremsagar changed the base branch from 21.12 to branch-22.02 January 19, 2022 17:13
@github-actions github-actions bot removed CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. labels Jan 19, 2022
@galipremsagar galipremsagar changed the title [WIP] Add struct generation support in datagenerator & fuzz tests [REVIEW] Add struct generation support in datagenerator & fuzz tests Jan 19, 2022
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress inactive-30d labels Jan 19, 2022
@galipremsagar galipremsagar marked this pull request as ready for review January 19, 2022 17:19
@galipremsagar galipremsagar requested a review from a team as a code owner January 19, 2022 17:19
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jan 20, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

1 similar comment
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar removed the request for review from skirui-source January 20, 2022 13:19
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 690993c into rapidsai:branch-22.02 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Cover struct columns in fuzz testing
2 participants
@galipremsagar @rgsl888prabhu