-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various internal MultiIndex improvements #9243
Various internal MultiIndex improvements #9243
Conversation
Two notes:
|
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9243 +/- ##
===============================================
Coverage ? 10.89%
===============================================
Files ? 115
Lines ? 19087
Branches ? 0
===============================================
Hits ? 2080
Misses ? 17007
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A delightful stroll down memory lane. Great job digging through the miserable special cases of MultiIndex
, thanks!
Temporarily leaving this PR pointing to branch-21.10 to for CI, but moving to the 21.12 milestone. Will retarget the PR once changes are finalized (or 21.12 CI is up and running). |
Overall this is looking good to me. It might be able to make it into 21.10 if there aren't any other major changes (not sure when burn down is though.) |
@galipremsagar once you're happy with this it's up to you whether you want to merge this into 21.10 or 21.12. It seems like it's basically ready, but as we discussed offline (and commented on this thread above) it may be wiser to hold off until 21.12 to avoid any last minute surprises. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets merge this into branch-21.12
as discussed offline. Can you rebase the changes?
… and remove unnecessary mask method.
Wow I completely borked the merge somehow. Going to rebase, will need to remove unnecessary requested reviewers. |
e8fa910
to
be05fa1
Compare
Ah I think I see the problem. Has forward-merge from 21.10->21.12 not been set up yet? I think I had commits from merging 21.10 in my PR that were not yet present on 21.12. |
…th version from 21.10 to prevent forward merge issues.
I had fixed a typo in a test created in #9258, which led to conflicts from merges. I've removed that change entirely to avoid causing issues with the 21.10->21.12 forward merge once it's introduced. |
@gpucibot merge |
This PR is a follow-up to #9191 to further simplify the MultiIndex class. It removes various unused functions, inlines and simplifies a number of other single-use internal functions, and moves more methods to Frame that can be shared. It also makes numerous other miscellaneous improvements to the code in MultiIndex to simplify further rewrites.